Path: csiph.com!usenet.pasdenom.info!news.albasani.net!news.mixmin.net!feed.xsnews.nl!border-1.ams.xsnews.nl!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.025 X-Spam-Evidence: '*H*': 0.95; '*S*': 0.00; 'subject:code': 0.07; 'already.': 0.09; 'long)': 0.09; 'thread': 0.11; '12:57': 0.16; 'code?': 0.16; 'received:internode.on.net': 0.16; 'received:on.net': 0.16; 'thread.': 0.16; 'wed,': 0.16; 'wrote:': 0.17; 'appears': 0.18; 'code.': 0.20; 'variable': 0.20; "i'd": 0.22; 'to:2**1': 0.23; 'cheers': 0.24; 'header:In-Reply-To:1': 0.25; 'header:User-Agent:1': 0.26; 'appear': 0.26; 'wondering': 0.26; 'topic': 0.27; 'dos': 0.27; 'chris': 0.28; 'dialog': 0.29; 'probably': 0.29; 'usually': 0.30; 'feedback': 0.30; 'code': 0.31; 'submitting': 0.32; 'to:no real name:2**1': 0.32; 'could': 0.32; 'received:com.au': 0.33; 'true.': 0.33; 'to:addr:python-list': 0.33; 'third': 0.34; 'doing': 0.35; 'pm,': 0.35; 'really': 0.36; 'but': 0.36; 'expensive': 0.36; 'received:au': 0.36; 'should': 0.36; 'does': 0.37; 'data': 0.37; 'subject:: ': 0.38; 'some': 0.38; 'to:addr:python.org': 0.39; 'your': 0.60; 'most': 0.61; 'maximum': 0.63; 'more': 0.63; 'gone': 0.64; 'jul': 0.65; 'watching': 0.65; 'transfer': 0.76; 'limits,': 0.84; 'received:118': 0.93 Date: Wed, 04 Jul 2012 14:55:41 +1000 From: Simon Cropper User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: python-list@python.org, tyler@tysdomain.com Subject: Re: code review References: <6c39594f-79cb-4d4f-967e-bbc3f68cdbdf@f8g2000pbf.googlegroups.com> <4fed59b7$0$29978$c3e8da3$5496439d@news.astraweb.com> <16ab546d-79e8-4d9a-9f8b-a28494d885f7@email.android.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - lincpan30.siteportal.com.au X-AntiAbuse: Original Domain - python.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - fossworkflowguides.com X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 34 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1341377755 news.xs4all.nl 6869 [2001:888:2000:d::a6]:39548 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:24847 On 04/07/12 13:53, Chris Angelico wrote: > On Wed, Jul 4, 2012 at 12:57 PM, wrote: >> Well, if you waited until you had the password (however long) in a variable before you applied your maximum limits, the DoS ship has probably sailed already. > > Only because data transfer is usually more expensive than hashing. But > I'd say that'll always be true. > > ChrisA > Some questions to Tyler Littlefield, who started this thread. Q1 -- Did you get any constructive feedback on your code? Q2 -- Did you feel that the process of submitting your code for review met your expectation? Q3 -- Would you recommend others doing this either on this forum or other fora? It appears to me - third party watching the ongoing dialog - that the tread has gone right off topic (some time ago) and someone should really start a new thread under a new title/subject. Most of what I have read does not appear to be discussing your code or how you could improve your code. Following the last few posts, I was wondering whether some other off-list dialog is going on or whether I am missing something. -- Cheers Simon