Path: csiph.com!usenet.pasdenom.info!gegeweb.org!usenet-fr.net!nerim.net!novso.com!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.006 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'repository': 0.05; 'subject:code': 0.07; 'git': 0.09; 'def': 0.10; "wouldn't": 0.11; 'sat,': 0.15; '12:57': 0.16; 'empty.': 0.16; 'grounds': 0.16; 'simplified': 0.16; 'thought.': 0.16; 'wrote:': 0.17; 'thu,': 0.17; '>>>': 0.18; 'code,': 0.18; 'sender:addr:gmail.com': 0.18; 'code.': 0.20; 'received:74.125.82.174': 0.23; "haven't": 0.23; 'header:In-Reply-To:1': 0.25; 'appreciated.': 0.26; 'am,': 0.27; 'message-id:@mail.gmail.com': 0.27; 'rest': 0.28; 'actual': 0.28; '-0700,': 0.29; '>>>>': 0.29; "d'aprano": 0.29; 'steven': 0.29; 'url:code': 0.29; "i'm": 0.29; 'fri,': 0.30; 'at:': 0.31; 'code': 0.31; 'point': 0.31; 'received:74.125.82': 0.33; 'curious': 0.33; 'passwords': 0.33; 'to:addr:python-list': 0.33; 'received:google.com': 0.34; 'project': 0.34; 'pm,': 0.35; 'next': 0.35; 'but': 0.36; 'received:74.125': 0.36; 'subject:: ': 0.38; 'some': 0.38; 'page': 0.38; 'to:addr:python.org': 0.39; 'skip:" 10': 0.40; 'header:Received:5': 0.40; 'think': 0.40; '30,': 0.62; 'maximum': 0.63; 'url:p': 0.63; 'information': 0.63; "everything's": 0.84; 'sorry.': 0.91 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:content-type; bh=Q76PuLHr3ckxYXEIUSf43gCb8UtGNMeaZr64tQLqaRE=; b=LAax5rPGhNjTiGGIJL0lx99hv2uCjodeLlcSBgJW0LvVLOMK27bHcNSuddqFcuigzk eVXiCyT6tLzosywStyf8jR05IPznasZx1Xs7Y93XILimV0mNXGRbDGrhXOdt/8nOpE2d bNWteunzeibAAJqn/7a5WFdQQvxCXMk4gdwf1TEFjffmQZaIYPHHi4vOzWZcchtIKtrk qu4sCyKxdTTal9BBUAxQcU0pIaQOouYYhxnIo0ynDujLTltyFcrjDwLpOpHAJKx+N18J 5nW34SsjjyCUhmmnzqglY8JLpraXB/pqnNkZ7XtybGgdTeTP21c63FVn55pBhWQAI5UW 4aPA== MIME-Version: 1.0 Sender: kushal.kumaran@gmail.com In-Reply-To: References: <6c39594f-79cb-4d4f-967e-bbc3f68cdbdf@f8g2000pbf.googlegroups.com> <4fed59b7$0$29978$c3e8da3$5496439d@news.astraweb.com> From: Kushal Kumaran Date: Tue, 3 Jul 2012 23:23:34 +0530 X-Google-Sender-Auth: dUY_fmxLAErPzPGNQiowx6IlMhs Subject: Re: code review To: Python User Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 34 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1341338042 news.xs4all.nl 6941 [2001:888:2000:d::a6]:36753 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:24827 On Sat, Jun 30, 2012 at 3:34 PM, Alister wrote: > On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote: > >> On 6/29/2012 1:31 AM, Steven D'Aprano wrote: >>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote: >>> >>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" wrote: >>>>> I was curious if someone wouldn't mind poking at some code. The >>>>> project page is at:http://code.google.com/p/pymud Any information is >>>>> greatly appreciated. >>>> I couldn't find any actual code at that site, the git repository is >>>> currently empty. >> >> OOPS, sorry. Apparently I'm not as good with git as I thought. >> Everything's in the repo now. > > I think I may be on firmer grounds with the next few: > > isValidPassword can be simplified to > > def isValidPassword(password: > count=len(password) > return count>= mud.minpass and count<= mud.maxpass > I haven't actually seen the rest of the code, but I would like to point out that applications placing maximum length limits on passwords are extremely annoying. > -- regards, kushal