Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed5.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.005 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'repository': 0.05; 'subject:code': 0.07; 'git': 0.09; 'referencing': 0.09; "wouldn't": 0.11; 'cases': 0.15; '12:57': 0.16; 'empty.': 0.16; 'from:addr:mrabarnett.plus.com': 0.16; 'from:addr:python': 0.16; 'from:name:mrab': 0.16; 'investigate': 0.16; 'message- id:@mrabarnett.plus.com': 0.16; 'received:84.93': 0.16; 'received:84.93.230': 0.16; 'thought.': 0.16; 'wrote:': 0.17; 'odd': 0.17; 'thu,': 0.17; '>>>': 0.18; 'code.': 0.20; 'bit': 0.21; 'import': 0.21; 'header:In-Reply-To:1': 0.25; 'header:User- Agent:1': 0.26; 'appreciated.': 0.26; 'am,': 0.27; 'actual': 0.28; '-0700,': 0.29; '>>>>': 0.29; "d'aprano": 0.29; 'received:192.168.1.3': 0.29; 'steven': 0.29; 'url:code': 0.29; "i'm": 0.29; 'classes': 0.30; 'fri,': 0.30; 'at:': 0.31; 'code': 0.31; 'received:84': 0.32; 'curious': 0.33; 'to:addr:python-list': 0.33; 'project': 0.34; 'pm,': 0.35; 'but': 0.36; 'far': 0.37; 'subject:: ': 0.38; 'some': 0.38; 'page': 0.38; 'to:addr:python.org': 0.39; 'received:192': 0.39; 'skip:" 10': 0.40; 'received:192.168': 0.40; 'think': 0.40; 'most': 0.61; 'expert': 0.62; 'url:p': 0.63; 'information': 0.63; 'header:Reply- To:1': 0.68; 'reply-to:no real name:2**0': 0.72; "everything's": 0.84; 'reply-to:addr:python.org': 0.84; 'sorry.': 0.91 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.0 cv=AYoz7grG c=1 sm=1 a=0nF1XD0wxitMEM03M9B4ZQ==:17 a=YsUzL_8ObRgA:10 a=ihvODaAuJD4A:10 a=OUOv7kDek9cA:10 a=8nJEP1OIZ-IA:10 a=EBOSESyhAAAA:8 a=8AHkEIZyAAAA:8 a=Bw3JSddfAAAA:8 a=1XWaLZrsAAAA:8 a=-YzKSU3IZVxAJJL_JFoA:9 a=wPNLvfGTeEIA:10 a=W68FkdOO9sQA:10 a=0nF1XD0wxitMEM03M9B4ZQ==:117 X-AUTH: mrabarnett:2500 Date: Fri, 29 Jun 2012 21:09:06 +0100 From: MRAB User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: python-list@python.org Subject: Re: code review References: <6c39594f-79cb-4d4f-967e-bbc3f68cdbdf@f8g2000pbf.googlegroups.com> <4fed59b7$0$29978$c3e8da3$5496439d@news.astraweb.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: python-list@python.org List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 39 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1341000547 news.xs4all.nl 6970 [2001:888:2000:d::a6]:42412 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:24674 On 29/06/2012 20:41, Alister wrote: > On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote: > >> On 6/29/2012 1:31 AM, Steven D'Aprano wrote: >>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote: >>> >>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" wrote: >>>>> I was curious if someone wouldn't mind poking at some code. The >>>>> project page is at:http://code.google.com/p/pymud Any information is >>>>> greatly appreciated. >>>> I couldn't find any actual code at that site, the git repository is >>>> currently empty. >> >> OOPS, sorry. Apparently I'm not as good with git as I thought. >> Everything's in the repo now. > > I am no expert but from what have picked up so far > > from x import > > is frowned upon in most cases > I think you mean: from x import * > also this section in main strikes me as a bit odd and convoluted > > w = world() > serv = server(client) > w.server = serv > serv.world = w > > I think you are cross referencing classes & would be better to > investigate inheritance. > >