Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder4.news.weretis.net!feeder2.ecngs.de!ecngs!feeder.ecngs.de!xlned.com!feeder5.xlned.com!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.009 X-Spam-Evidence: '*H*': 0.98; '*S*': 0.00; 'things.': 0.05; 'subject:code': 0.07; 'broke': 0.09; "wouldn't": 0.11; 'from:addr:tyler': 0.16; 'from:addr:tysdomain.com': 0.16; 'from:name:littlefield, tyler': 0.16; 'message-id:@tysdomain.com': 0.16; 'peek': 0.16; 'received:69.164': 0.16; 'received:69.164.206': 0.16; 'received:69.164.206.65': 0.16; 'received:tds-solutions.net': 0.16; 'there?': 0.16; 'fix': 0.17; 'code.': 0.20; 'are:': 0.20; 'trying': 0.21; 'all:': 0.22; "i'd": 0.22; 'idea': 0.24; 'header:User-Agent:1': 0.26; 'appreciated.': 0.26; 'realize': 0.27; 'concern': 0.29; 'project:': 0.29; 'url:code': 0.29; "i'm": 0.29; 'framework': 0.30; 'at:': 0.31; '(and': 0.32; 'could': 0.32; 'curious': 0.33; 'to:addr:python- list': 0.33; 'another': 0.33; 'project': 0.34; 'so,': 0.35; 'doing': 0.35; 'received:192.168.0': 0.35; 'something': 0.35; 'there': 0.35; 'but': 0.36; 'totally': 0.36; 'does': 0.37; 'far': 0.37; 'some': 0.38; 'things': 0.38; 'sure': 0.38; 'page': 0.38; 'to:addr:python.org': 0.39; 'received:192': 0.39; 'received:192.168': 0.40; 'url:p': 0.63; 'information': 0.63; 'taking': 0.65; 'concerns': 0.65; 'light-weight': 0.84; 'ok?': 0.84; 'care,': 0.91 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on wuff X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable version=3.3.1 Date: Thu, 28 Jun 2012 20:57:44 -0600 From: "Littlefield, Tyler" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: python-list@python.org Subject: code review Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 26 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1340939178 news.xs4all.nl 6848 [2001:888:2000:d::a6]:40796 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:24643 Hello all: I was curious if someone wouldn't mind poking at some code. I have an idea for a game I want to write (and if this works I want to use this as a framework for another project), but I'd like to make sure I'm doing things correctly/there's not a better way to do things. My concern is I'm going to get way far into this, then realize I totally broke something. So, if someone wouldn't mind taking a peek I'd appreciate it. My concerns are: 1) style/cleanlyness: does everything look ok? 2) Workability: is there a better way to do what is there? 3) Speed: am I doing something that could be improved? I don't want to spend a ton of time looking for non-existent bottlenecks and trying to improve on them, but if I'm doing something that's bad, I'd like to fix it. The project page is at: http://code.google.com/p/pymud Any information is greatly appreciated. -- Take care, Ty http://tds-solutions.net The aspen project: a barebones light-weight mud engine: http://code.google.com/p/aspenmud He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.