Path: csiph.com!usenet.pasdenom.info!news.redatomik.org!newsfeed.xs4all.nl!newsfeed4.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
To: python-list@python.org
From: Terry Reedy <tjreedy@udel.edu>
Subject: Re: Function Defaults - avoiding unneccerary combinations of arguments at input
Date: Wed, 25 Mar 2015 16:19:35 -0400
References: <009d01d06723$38860d50$a99227f0$@gmail.com> <meuvkb$e5t$1@ger.gmane.org> <000801d06734$f9e57830$edb06890$@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
In-Reply-To: <000801d06734$f9e57830$edb06890$@gmail.com>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.160.1427314812.10327.python-list@python.org>
Lines: 48
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:87978

On 3/25/2015 3:50 PM, Ivan Evstegneev wrote:

> Googled a bit, and found only one, a "ValueError" exception, but still don't
> understand how it should be implemented in my case.
>
> Should my code look like this one:
>
> def  my_fun(history=False, built=False, current=False, topo=None,
> full=False, file=None):
> 	try:
> 		if currnet and full:
> 			do something_1
> 		elif current and file:
> 			do something_2
> 		elif history and full and file:
> 			do something_3
> 	
> 	except ValueError:
> 		print("No valid input! Please try again ...")

You need to raise ValueError, not try to catch one that never occurs.

def  my_fun(history=False, built=False, current=False, topo=None,
full=False, file=None):
     if current and full:
         do something_1
     elif current and file:
         do something_2
     elif history and full and file:
         do something_3
     else:
         raise ValueError("not a valid combination of arguments")

My answer does not negate the possibility that Ian is correct that you 
are trying to do too much in one function.  But I did want to point out 
that there are stdlib precedents for excluding invalid argument 
combinations.  However, in those cases, only a small proportion of 
combinations are invalid and if the function were split, most of the 
code would be duplicated.

Here is an mutually exclusive combo that is *not* flagged: passing both 
'-' (read from stdin) and 'file.py' to python on the command line.  The 
first wins and the second is ignored.  '-i -' is redundant and ignored.


-- 
Terry Jan Reedy