Path: csiph.com!usenet.pasdenom.info!news.redatomik.org!newsfeed.xs4all.nl!newsfeed7.news.xs4all.nl!nzpost1.xs4all.net!not-for-mail
Date: Fri, 25 Sep 2015 09:25:38 +1000
From: Cameron Simpson <cs@zip.com.au>
To: python-list@python.org
Subject: Re: ConnectionError handling problem
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <201509241038.t8OAcT1Z013215@fido.openend.se>
User-Agent: Mutt/1.5.23 (2014-03-12)
References: <201509241038.t8OAcT1Z013215@fido.openend.se>
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.157.1443140162.28679.python-list@python.org>
Lines: 47
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:97107

On 24Sep2015 12:38, Laura Creighton <lac@openend.se> wrote:
>In a message of Wed, 23 Sep 2015 19:49:17 -0700, shiva upreti writes:
>>If my script hangs because of the reasons you mentioned above, why doesnt it 
>>catch ConnectionError?
>>My script stops for a while and when I press CTRL+C, it shows ConnectionError without terminating the process, and the script resumes from where it left off.
>
>This is exactly what you asked it to do. :)
>
>>> 		try:
>>>  			r=requests.post(url, data=query_args)
>>> 		except:
>>> 			print "Connection error"
>>> 			time.sleep(30)
>>> 			continue
>
>try to do something until you get an Exception.  Since that is a
>naked except, absolutely any Exception will do.  That you
>print out 'Connection error' doesn't mean that you are only
>catching exceptions raised by trying to send something to the
>other end ... any Exception will do.
[... snip ...]

Since nobody has offered this advice, let me:

Firstly, as already remarked bare excepts are overkill - they catch all sorts 
of things you shouldn't be handling.

That said, if you _don't know_ what exceptions are going to boils out of new 
code, this is one way to see them all. However, you are catching _everything_ 
but _not_ finding out what happened.

Try this:

    try:
        r=requests.post(url, data=query_args)
    except Exception as e:
        print "Exception:", e

That will at least _tell_ you what happened. You code is blithely presuming 
Connection Error and telling you that, but it is usually a lie.

Once you have characterised what exceptions you get, and which particular ones 
to handle, then modify your code to catch _only_ those and perform the specific 
suitable actions, and let the rest escape.

Cheers,
Cameron Simpson <cs@zip.com.au>