Path: csiph.com!usenet.pasdenom.info!weretis.net!feeder1.news.weretis.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
Date: Thu, 09 May 2013 16:54:34 +0100
From: MRAB <python@mrabarnett.plus.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: python-list@python.org
Subject: Re: Urgent:Serial Port Read/Write
References: <1368113753.5157.YahooMailClassic@web190506.mail.sg3.yahoo.com>
In-Reply-To: <1368113753.5157.YahooMailClassic@web190506.mail.sg3.yahoo.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Reply-To: python-list@python.org
Newsgroups: comp.lang.python
Message-ID: <mailman.1496.1368114871.3114.python-list@python.org>
Lines: 138
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:45042

On 09/05/2013 16:35, chandan kumar wrote:
> Hi all,
> I'm new to python and facing issue using serial in python.I'm facing the
> below error
>
> *    ser.write(port,command)*
> *NameError: global name 'ser' is not defined*
> *
> *
> Please find the attached script and let me know whats wrong in my script
> and also how can i read data from serial port for the  same script.
>
>
> Best Regards,
> Chandan.
>
>
> RunScripts.py
>
>
> import time
> import os
> import serial
> import glob
>
>
> ER_Address = [[0x0A,0x01,0x08,0x99,0xBB,0xBB,0xBB,0xBB,0xBB,0xBB,0xBB]]
> """
> ----------------------------------------------------------------------------------------------------------------------------
> Function Name: RunSequence
> ----------------------------------------------------------------------------------------------------------------------------
> Function Description:
> ---------------------
> A RunSequence function has Multiple calls to the RunSuite function, each call is a single testcase consisting of all the parameters
> required by the RunTesSuite.
> -----------------------------------------------------------------------------------------------------------------------------
> """
> def WriteSerialData(command):

'ser' isn't a local variable (local to this function, that is), nor is
it a global variable (global in this file).

>      ser.write(port,command)
>
> def SendPacket(Packet):
>      str = chr(len(Packet)) + Packet #Concatenation of Packet with the PacketLength
>      print str
>      WriteSerialData(str)
>
>
> def CreateFrame(Edata):

It's more efficient to build a list of the characters and then join
them together into a string in one step than to build the string one
character at a time.

Also, indexing into the list is considered 'unPythonic'; it's much 
simpler to do it this way:

     return chr(0x12) + "".join(chr(d) for d in Edata)

>          evt = chr(0x12)
>          evt = evt + chr(Edata[0])
>          for i in range (1, len(Edata)):
>              evt = evt + chr(Edata[i])
>          return evt
>
> def SetRequest(data):
>      print data
>      new = []
>      new = sum(data, [])
>      Addr = CreateFrame(new)
>      SendPacket(Addr)
>      print "SendPacket Done"
>      ReadPacket()
>
>
> def OpenPort(COMPort,BAUDRATE):
>      """
>      This function reads the serial port and writes it.
>      """
>      comport=COMPort
>      BaudRate=BAUDRATE
>      try:
>          ser = serial.Serial(
>              port=comport,
>              baudrate=BaudRate,
>              bytesize=serial.EIGHTBITS,
>              parity=serial.PARITY_NONE,
>              stopbits=serial.STOPBITS_ONE,
>              timeout=10,
>              xonxoff=0,
>              rtscts=0,
>              dsrdtr=0
>              )
>
>          if ser.isOpen():
>              print "Port Opened"
>              ser.write("Chandan")
>              string1 = ser.read(8)
>              print string1

This function returns either ser ...

>              return ser
>          else:
>              print "Port CLosed"
>              ser.close()

... or 3 ...
>              return 3
>      except serial.serialutil.SerialException:
>          print "Exception"
>          ser.close()
>
... or None!
>
>
>
>
>
> if __name__ == "__main__":
>
>      CurrDir=os.getcwd()
>      files = glob.glob('./*pyc')
>      for f in files:
>          os.remove(f)

OpenPort returns either ser or 3 or None, but the result is just
discarded.

>      OpenPort(26,9600)
>      SetRequest(ER_Address)
>      #SysAPI.SetRequest('ER',ER_Address)
>
>      print "Test Scripts Execution complete"
>