Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.xs4all.nl!newsfeed2.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.000 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'python.': 0.02; 'parameters': 0.04; 'schema': 0.05; 'string': 0.09; '"("': 0.09; 'driver,': 0.09; 'parameter': 0.09; 'subject:string': 0.09; 'def': 0.12; 'stored': 0.12; '"."': 0.16; 'commas:': 0.16; 'concatenate': 0.16; 'from:addr:mrabarnett.plus.com': 0.16; 'from:addr:python': 0.16; 'from:name:mrab': 0.16; 'message-id:@mrabarnett.plus.com': 0.16; 'received:192.168.1.4': 0.16; 'received:84.93': 0.16; 'received:84.93.230': 0.16; 'stuff.': 0.16; 'there?': 0.16; 'tuple': 0.16; 'subject:python': 0.16; 'wrote:': 0.18; 'bit': 0.19; 'header:User-Agent:1': 0.23; 'fairly': 0.24; 'looks': 0.24; 'question': 0.24; 'skip:" 20': 0.27; 'header:In-Reply-To:1': 0.27; 'function': 0.29; 'correct': 0.29; 'code': 0.31; 'parameters.': 0.31; 'text': 0.33; 'skip:s 30': 0.35; 'received:84': 0.35; 'but': 0.35; 'there': 0.35; 'hi,': 0.36; 'list': 0.37; 'to:addr:python- list': 0.38; 'to:addr:python.org': 0.39; 'skip:p 20': 0.39; 'called': 0.40; 'how': 0.40; 'new': 0.61; 'simple': 0.61; 'email addr:gmail.com': 0.63; 'ugly,': 0.84 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.1 cv=S6lXwecP c=1 sm=1 tr=0 a=0nF1XD0wxitMEM03M9B4ZQ==:117 a=0nF1XD0wxitMEM03M9B4ZQ==:17 a=0Bzu9jTXAAAA:8 a=u9EReRu7m0cA:10 a=E9Xv7Y2Gd4MA:10 a=AdgJCnLbEhEA:10 a=ihvODaAuJD4A:10 a=IkcTkHD0fZMA:10 a=EBOSESyhAAAA:8 a=pGLkceISAAAA:8 a=Swr7o9XhfZ_tVN5hN7YA:9 a=QEXdDO2ut3YA:10 a=MSl-tDqOz04A:10 X-AUTH: mrabarnett:2500 Date: Wed, 27 Aug 2014 23:42:37 +0100 From: MRAB User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: python-list@python.org Subject: Re: python string, best way to concat References: <55bab2a0-e0bc-4398-90b4-c9937498f5d8@googlegroups.com> In-Reply-To: <55bab2a0-e0bc-4398-90b4-c9937498f5d8@googlegroups.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 48 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1409179359 news.xs4all.nl 2951 [2001:888:2000:d::a6]:36260 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:77169 On 2014-08-27 21:31, dennisearlevans@gmail.com wrote: > > Hi, > > Sorry about the simple question but I am very new to Python. > > Anyway, I have a function that will be used to call a stored procedure and I need to format the string with the correct number of parameter markers for the ODBC driver, fairly standard stuff. > > What I have works but looks ugly, is there a better way to build or concatenate a string or is a list or a tuple a better option? > > the function looks like this > > def callSp(self, schema, spName) : > sqlCode = "{call " + schema + "." + spName + "(" > par_Markers = "" > y = len(self.param) > x = 0 > while x < y : > par_Markers = par_Markers.join("?") > if (x < y - 1) : > par_Markers = par_Markers.join(", ") > x += 1 > self.cmdText = sqlCode + par_Markers + ")}" > self.ExecuteCursor() > > return > How many parameters are there? len(self.param) Make that many placeholders and then join them together with commas: ', '.join(['?'] * len(self.param)) > self.param is a list of parameters. sself.cmdText is the text that will be used to call the stored procedure. > > the function would be called like this > > class.AddParameter(some value 1) > class.AddParameter(some value 2) > callSp("schemaName", "storedProcedureName") > > the self.cmdText will look like this just before the ExecuteCursor call > > "{call schemaName.StoredProcedureName(?, ?)}" > > the code works, but as I said is a bit ugly, is there better methods? >