Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!news.stack.nl!newsfeed.xs4all.nl!newsfeed1a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
Return-Path: <python-python-list@m.gmane.org>
X-Original-To: python-list@python.org
Delivered-To: python-list@mail.python.org
X-Spam-Status: OK 0.000
X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'else:': 0.03; 'context': 0.07; 'callback': 0.09; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'release,': 0.09; 'def': 0.12; '"release': 0.16; 'defer': 0.16; 'received:80.91.229.3': 0.16; 'received:plane.gmane.org': 0.16; 'stack:': 0.16; 'subject: \n ': 0.16; 'subject:lock': 0.16; 'subject:when': 0.16; 'timeout)': 0.16; 'two.': 0.16; 'unexpected': 0.16; 'exception': 0.16; 'sat,': 0.16; 'wrote:': 0.18; 'acquired': 0.19; 'aug': 0.22; 'header:User- Agent:1': 0.23; 'header:X-Complaints-To:1': 0.27; 'header:In- Reply-To:1': 0.27; 'correct': 0.29; 'chris': 0.29; 'am,': 0.29; "doesn't": 0.30; 'another': 0.32; 'could': 0.34; 'common': 0.35; 'yield': 0.36; 'to:addr:python-list': 0.38; 'pm,': 0.38; 'to:addr:python.org': 0.39; 'received:org': 0.40; 'happen': 0.63; 'between': 0.67; 'natural': 0.68; 'atomic': 0.84; 'suffer': 0.93; 'race': 0.95
X-Injected-Via-Gmane: http://gmane.org/
To: python-list@python.org
From: "Neil D. Cerutti" <neilc@norwich.edu>
Subject: Re: Specifying `blocking` and `timeout` when acquiring lock as a context manager
Date: Fri, 08 Aug 2014 14:35:28 -0400
References: <ff17939d-84cc-4f86-a5b9-9056d76dc9c0@googlegroups.com> <53E4CFD9.4080209@stoneleaf.us> <ls2sh7$eip$1@ger.gmane.org> <CAPTjJmpvfrEPc3tGVfhNS1W2bo9B4QR7AkK99yxMyOZND4woNQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Gmane-NNTP-Posting-Host: jackman.norwich.edu
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
In-Reply-To: <CAPTjJmpvfrEPc3tGVfhNS1W2bo9B4QR7AkK99yxMyOZND4woNQ@mail.gmail.com>
X-BeenThere: python-list@python.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: General discussion list for the Python programming language <python-list.python.org>
List-Unsubscribe: <https://mail.python.org/mailman/options/python-list>, <mailto:python-list-request@python.org?subject=unsubscribe>
List-Archive: <http://mail.python.org/pipermail/python-list/>
List-Post: <mailto:python-list@python.org>
List-Help: <mailto:python-list-request@python.org?subject=help>
List-Subscribe: <https://mail.python.org/mailman/listinfo/python-list>, <mailto:python-list-request@python.org?subject=subscribe>
Newsgroups: comp.lang.python
Message-ID: <mailman.12758.1407522945.18130.python-list@python.org>
Lines: 35
NNTP-Posting-Host: 2001:888:2000:d::a6
X-Trace: 1407522945 news.xs4all.nl 2861 [2001:888:2000:d::a6]:45390
X-Complaints-To: abuse@xs4all.nl
Xref: csiph.com comp.lang.python:75901

On 8/8/2014 12:16 PM, Chris Angelico wrote:
> On Sat, Aug 9, 2014 at 2:05 AM, Neil D. Cerutti <neilc@norwich.edu> wrote:
>> Perhaps defer release, a la a common Go pattern:
>>
>> with contextlib.ExitStack() as stack:
>>      acquired = lock.acquire(blocking=False)
>>      if acquired:
>>          stack.callback(lock.release)
>>          do_stuff
>
> There's a race condition in that - an unexpected exception could
> happen between those two. Are you able to set the callback to be a
> "release if acquired" atomic operation?

Doesn't any natural looking use of blocking=False suffer from the same 
race condition? What's the correct way to use it?

Here's another attempt at context managing:

@contextlib.contextmanager
def release_if_acquired(lock, blocking=True, timeout=-1):
     acquired = lock.acquire(blocking, timeout)
     if acquired:
         yield acquired
         lock.release()
     else:
         yield acquired

with release_if_acquired(lock, blocking=False) as acquired:
     if acquired:
         do_stuff

-- 
Neil Cerutti