Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder2.hal-mli.net!de-l.enfer-du-nord.net!feeder2.enfer-du-nord.net!usenet-fr.net!nerim.net!novso.com!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <CAFB6qZsG6nns=_Vn5Fk6M8fvCVY_Ykh8ttH+r9Euz1+ed+iCRA@mail.gmail.com>
References: <CAFB6qZsG6nns=_Vn5Fk6M8fvCVY_Ykh8ttH+r9Euz1+ed+iCRA@mail.gmail.com>
From: Devin Jeanpierre <jeanpierreda@gmail.com>
Date: Thu, 2 May 2013 22:23:11 -0400
Subject: Re: question about try/except blocks
To: Python List <python-list@python.org>
Content-Type: text/plain; charset=UTF-8
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.1261.1367547835.3114.python-list@python.org>
Lines: 41
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:44653

On Thu, May 2, 2013 at 9:54 PM, J <dreadpiratejeff@gmail.com> wrote:
> Would it be better to wrap the call and catch the OSError there, or
> wrap the whole with open() block in the function itself?
>
> My thought is to wrap the with open() call in the function so that I'm
> not wrapping the function call every time I use the class somewhere,
> but then I am not sure of that as it leads to nested try blocks like
> so:

It definitely shouldn't be done that way, since you might catch
exceptions in other circumstances too. Try this:

try:
    f = open(dest, 'wb', 0)
except OSError as exc:
    ...
with f:
    try:
        ...
    except IOError as exc:
        ...
    else:
        ...

-- Devin

> try:
>     with open(dest, 'wb', 0) as outfile:
>         try:
>             stuff
>         except IOError as exec:
>             more stuff
>         else:
>             other stuff
> except OSError as exc:
>      error handling stuff
>      return False
>
>
> I think, functionally, that should work, but should nested try/except
> blocks be avoided?