Path: csiph.com!usenet.pasdenom.info!aioe.org!news.stack.nl!newsfeed.xs4all.nl!newsfeed4a.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail
MIME-Version: 1.0
In-Reply-To: <lpe60l$1st$1@ger.gmane.org>
References: <53ba11fc$0$29985$c3e8da3$5496439d@news.astraweb.com> <c1uo2eF60gfU1@mid.individual.net> <53ba538d$0$2926$c3e8da3$76491128@news.astraweb.com> <CAPTjJmos00xjJVMZFKY1F9Z8L+ByusHD-ciuats5FYbwQ6RF+g@mail.gmail.com> <lpe60l$1st$1@ger.gmane.org>
Date: Mon, 7 Jul 2014 09:07:43 -0700
Subject: Re: open() and EOFError
From: Dan Stromberg <drsalists@gmail.com>
To: Mark Lawrence <breamoreboy@yahoo.co.uk>
Content-Type: text/plain; charset=UTF-8
Cc: python-list@python.org
Precedence: list
Newsgroups: comp.lang.python
Message-ID: <mailman.11598.1404749266.18130.python-list@python.org>
Lines: 36
NNTP-Posting-Host: 2001:888:2000:d::a6
Xref: csiph.com comp.lang.python:74120

On 7/7/14, Mark Lawrence <breamoreboy@yahoo.co.uk> wrote:
> On 07/07/2014 09:09, Chris Angelico wrote:
>> On Mon, Jul 7, 2014 at 6:00 PM, Steven D'Aprano <steve@pearwood.info>
>> wrote:
>>> How do people feel about code like this?
>>>
>>> try:
>>>      name = input("Enter file name, or Ctrl-D to exit")
>>>      # On Windows, use Ctrl-Z [enter] instead.
>>>      fp = open(name)
>>> except EOFError:
>>>      sys.exit()
>>> except IOError:
>>>      handle_bad_file(name)
>>> else:
>>>      handle_good_file(fp)
>>
>> It seems trivial in this example to break it into two try blocks:
>>
>> try:
>>      name = input("Enter file name, or Ctrl-D to exit")
>>      # On Windows, use Ctrl-Z [enter] instead.
>> except EOFError:
>>      sys.exit()
>> try:
>>      fp = open(name)
>> except IOError:
>>      handle_bad_file(name)
>> else:
>>      handle_good_file(fp)
>>
>
> All those extra lines to type, not on your life.  Surely it would be
> better written as a one liner?

Don't be afraid of a few extra keystrokes.  Clarity is king.