Path: csiph.com!x330-a1.tempe.blueboxinc.net!usenet.pasdenom.info!news.albasani.net!news.stack.nl!newsfeed.xs4all.nl!newsfeed6.news.xs4all.nl!xs4all!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.000 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'builtins': 0.07; 'received:verizon.net': 0.07; 'subject:when': 0.07; 'terry': 0.07; 'python': 0.08; 'received:80.91': 0.09; 'received:80.91.229': 0.09; 'received:80.91.229.12': 0.09; 'received:gmane.org': 0.09; 'received:list': 0.09; 'received:lo.gmane.org': 0.09; 'code?': 0.16; 'reedy': 0.16; 'semanchuk': 0.16; 'subject:builtin': 0.16; 'terry,': 0.16; 'wrote:': 0.16; 'jan': 0.19; 'header:In-Reply- To:1': 0.22; 'pm,': 0.24; 'variable': 0.24; 'expect': 0.25; 'saying': 0.26; 'skip:_ 20': 0.28; 'second': 0.29; 'example': 0.30; 'lines': 0.30; 'subject:?': 0.31; 'there': 0.33; 'to:addr :python-list': 0.33; 'header:User-Agent:1': 0.34; 'be.': 0.34; 'header:X-Complaints-To:1': 0.35; 'example,': 0.37; 'open': 0.37; 'received:org': 0.38; 'subject:: ': 0.39; 'header:Mime-Version:1': 0.39; "there's": 0.39; 'to:addr:python.org': 0.39; 'might': 0.40; 'your': 0.61; 'exclusive': 0.78; 'open,': 0.91 X-Injected-Via-Gmane: http://gmane.org/ To: python-list@python.org From: Terry Reedy Subject: Re: Why no warnings when re-assigning builtin names? Date: Tue, 16 Aug 2011 22:15:03 -0400 References: <4e49c89a$0$30001$c3e8da3$5496439d@news.astraweb.com> <4e49fcd7$0$29974$c3e8da3$5496439d@news.astraweb.com> <5E204ED4-4008-416F-9C5F-DDCDCF6077D3@semanchuk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Gmane-NNTP-Posting-Host: pool-74-109-121-73.phlapa.fios.verizon.net User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 In-Reply-To: <5E204ED4-4008-416F-9C5F-DDCDCF6077D3@semanchuk.com> X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 24 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1313547609 news.xs4all.nl 23861 [2001:888:2000:d::a6]:52068 X-Complaints-To: abuse@xs4all.nl Xref: x330-a1.tempe.blueboxinc.net comp.lang.python:11651 On 8/16/2011 8:18 PM, Philip Semanchuk wrote: > Hi Terry, > To generalize from your example, are you saying that there's a mild admonition > against shadowing builtins with unrelated variable names in standard lib code? I would expect that there might be. I would have to check PEP8. > Here's an example from Python 3.2.1's argparse.py, lines 466-473. > "open" is shadowed on the second line. > > # clean up separators for mutually exclusive groups > open = r'[\[(]' > close = r'[\])]' > text = _re.sub(r'(%s) ' % open, r'\1', text) > text = _re.sub(r' (%s)' % close, r'\1', text) > text = _re.sub(r'%s *%s' % (open, close), r'', text) > text = _re.sub(r'\(([^|]*)\)', r'\1', text) > text = text.strip() -- Terry Jan Reedy