Path: csiph.com!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.freenet.ag!newsfeed0.kamp.net!newsfeed.kamp.net!fu-berlin.de!uni-berlin.de!not-for-mail
From: Mark Lawrence <breamoreboy@yahoo.co.uk>
Newsgroups: comp.lang.python
Subject: Re: raise None
Date: Thu, 31 Dec 2015 15:58:56 +0000
Lines: 79
Message-ID: <mailman.109.1451577564.11925.python-list@python.org>
References: <56847239$0$1590$c3e8da3$5496439d@news.astraweb.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
In-Reply-To: <56847239$0$1590$c3e8da3$5496439d@news.astraweb.com>
Precedence: list
Xref: csiph.com comp.lang.python:101060

On 31/12/2015 00:09, Steven D'Aprano wrote:
> I have a lot of functions that perform the same argument checking each time:
>
> def spam(a, b):
>      if condition(a) or condition(b): raise TypeError
>      if other_condition(a) or something_else(b): raise ValueError
>      if whatever(a): raise SomethingError
>      ...
>
> def eggs(a, b):
>      if condition(a) or condition(b): raise TypeError
>      if other_condition(a) or something_else(b): raise ValueError
>      if whatever(a): raise SomethingError
>      ...
>
> Since the code is repeated, I naturally pull it out into a function:
>
> def _validate(a, b):
>      if condition(a) or condition(b): raise TypeError
>      if other_condition(a) or something_else(b): raise ValueError
>      if whatever(a): raise SomethingError
>
> def spam(a, b):
>      _validate(a, b)
>      ...
>
> def eggs(a, b):
>      _validate(a, b)
>      ...
>
> But when the argument checking fails, the traceback shows the error
> occurring in _validate, not eggs or spam. (Naturally, since that is where
> the exception is raised.) That makes the traceback more confusing than it
> need be.

I disagree.

>
> So I can change the raise to return in the _validate function:
>
> def _validate(a, b):
>      if condition(a) or condition(b): return TypeError
>      if other_condition(a) or something_else(b): return ValueError
>      if whatever(a): return SomethingError
>
> and then write spam and eggs like this:
>
> def spam(a, b):
>      ex = _validate(a, b)
>      if ex is not None: raise ex
>      ...
>
> It's not much of a gain though. I save an irrelevant level in the traceback,
> but only at the cost of an extra line of code everywhere I call the
> argument checking function.
>
> But suppose we allowed "raise None" to do nothing. Then I could rename
> _validate to _if_error and write this:
>
> def spam(a, b):
>      raise _if_error(a, b)
>      ...
>
>
> and have the benefits of "Don't Repeat Yourself" without the unnecessary,
> and misleading, extra level in the traceback.
>
> Obviously this doesn't work now, since raise None is an error, but if it did
> work, what do you think?
>

A lot of fuss over nothing.

-- 
My fellow Pythonistas, ask not what our language can do for you, ask
what you can do for our language.

Mark Lawrence