Path: csiph.com!usenet.pasdenom.info!news.albasani.net!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.001 X-Spam-Evidence: '*H*': 1.00; '*S*': 0.00; 'syntax': 0.03; 'importing': 0.04; 'cleanup': 0.07; 'subject:code': 0.07; 'python': 0.09; 'git': 0.09; 'imported': 0.09; 'cleaner': 0.16; 'clone': 0.16; 'from:addr:tyler': 0.16; 'from:addr:tysdomain.com': 0.16; 'from:name:littlefield, tyler': 0.16; 'message- id:@tysdomain.com': 0.16; 'received:69.164': 0.16; 'received:69.164.206': 0.16; 'received:69.164.206.65': 0.16; 'received:tds-solutions.net': 0.16; 'subject:request': 0.17; 'thanks,': 0.18; 'trying': 0.21; 'bit': 0.21; 'do.': 0.21; 'all:': 0.22; 'received:192.168.1.100': 0.22; "i've": 0.23; 'header:User- Agent:1': 0.26; 'appreciated.': 0.26; 'components': 0.27; 'run': 0.28; 'project:': 0.29; 'url:code': 0.29; 'probably': 0.29; "i'm": 0.29; 'code': 0.31; 'room': 0.32; 'handle': 0.33; 'problem': 0.33; 'to:addr:python-list': 0.33; 'another': 0.33; 'there': 0.35; 'wanted': 0.36; "didn't": 0.36; 'things': 0.38; 'to:addr:python.org': 0.39; 'received:192': 0.39; 'received:192.168': 0.40; 'url:p': 0.63; 'world': 0.63; 'gotten': 0.75; 'light-weight': 0.84; 'care,': 0.91; 'room,': 0.93 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on wuff X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=unavailable version=3.3.1 Date: Sat, 22 Sep 2012 14:13:49 -0600 From: "Littlefield, Tyler" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: python-list@python.org Subject: request for another code review Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 21 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1348344861 news.xs4all.nl 6886 [2001:888:2000:d::a6]:42787 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:29764 Hello all: I've gotten a bit farther into my python mud, and wanted to request another code review for style and the like. Mainly I'm concerned about player.py, world.py and components and other ways to handle what I'm trying to do. I didn't run pychecker just yet, so there are probably a ton of syntax errors; my problem was that world was importing room, and room imported world for functionality and that made things a mess. Ideas and suggestions for code cleanup and cleaner ways to do things would be appreciated. git clone https://code.google.com/p/pymud/ Thanks, -- Take care, Ty http://tds-solutions.net The aspen project: a barebones light-weight mud engine: http://code.google.com/p/aspenmud He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.