Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!feeds.phibee-telecom.net!newsfeed.xs4all.nl!newsfeed1a.news.xs4all.nl!xs4all!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.032 X-Spam-Evidence: '*H*': 0.94; '*S*': 0.00; 'explicit': 0.07; 'exits': 0.09; 'cc:addr:python-list': 0.11; 'from:addr:rosuav': 0.16; 'from:name:chris angelico': 0.16; 'gotcha.': 0.16; 'ought': 0.16; 'raised.': 0.16; 'return,': 0.16; 'wrote:': 0.18; 'seems': 0.21; 'cc:addr:python.org': 0.22; 'error': 0.23; 'cc:2**0': 0.24; 'first,': 0.26; 'subject:/': 0.26; 'header:In-Reply-To:1': 0.27; 'am,': 0.29; 'statement': 0.30; 'message-id:@mail.gmail.com': 0.30; 'code': 0.31; "i'd": 0.34; 'but': 0.35; 'received:google.com': 0.35; 'little': 0.38; 'kind': 0.63; 'real': 0.63; 'finally': 0.65; 'ethan': 0.84; 'furman': 0.84; 'subject:try': 0.84; 'to:none': 0.92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=gKUZv30KzYzdCgUlwbWoya90ZZrr0iThzoxnVtGljTQ=; b=y6dKuk0oiUHacCvXWbO5xAeAHXsYcsSvVOK99TYPyA3KT9bZqyvvikapZr0G9B54tu Tq3nh+q6s9gIUB81vX3XBBeuYZYoO3eSMVA3kaBrqw+T/IX9s7jklhPWxoZZGbJOeHOW I0QBFZO3MMKbw1AKRlM3TZgG4EAO14RWN577q6Ev/XmILo8v6ukETNdCJdQuldRrSr3h xtwId48x/61TAwTAQfJEBBHmiUVDYMfTNJ4PU+4/9I4+il8IFdqla5TjtASQ4LUOxsDA BcxVWEYu7W6fp7PpM5sx63s0uWjepwEjby9BmYVwYW+DbFYcbPVbA45ThAq7IUYocX/2 H3ow== MIME-Version: 1.0 X-Received: by 10.220.59.65 with SMTP id k1mr16018995vch.22.1402184842136; Sat, 07 Jun 2014 16:47:22 -0700 (PDT) In-Reply-To: <539396F3.5090508@stoneleaf.us> References: <0a89c96d-de62-42ad-be48-6107ce10d215@googlegroups.com> <539396F3.5090508@stoneleaf.us> Date: Sun, 8 Jun 2014 09:47:21 +1000 Subject: Re: try/except/finally From: Chris Angelico Cc: "python-list@python.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Newsgroups: comp.lang.python Message-ID: Lines: 10 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1402184850 news.xs4all.nl 2893 [2001:888:2000:d::a6]:43060 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:72938 On Sun, Jun 8, 2014 at 8:49 AM, Ethan Furman wrote: > I don't remember if I almost had this in real code or if I learned about it > first, but it can definitely be a gotcha. It seems to me that if the try > block exits with an explicit return, and then the finally block exits with > an explicit return, some kind of error ought to be raised. I'd go a little simpler: A return statement inside a finally block is code smell. ChrisA