Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!eu.feeder.erje.net!newsfeed.freenet.ag!news2.euro.net!newsgate.cistron.nl!newsgate.news.xs4all.nl!post.news.xs4all.nl!not-for-mail Return-Path: X-Original-To: python-list@python.org Delivered-To: python-list@mail.python.org X-Spam-Status: OK 0.004 X-Spam-Evidence: '*H*': 0.99; '*S*': 0.00; 'else:': 0.03; 'retrieved': 0.05; 'data:': 0.07; 'host,': 0.07; "%s'": 0.09; 'logic': 0.09; 'to:addr:comp.lang.python': 0.09; 'cc:addr:python-list': 0.10; "wouldn't": 0.11; '%s,': 0.16; '(%s,': 0.16; 'entry.': 0.16; 'expected,': 0.16; 'hits': 0.16; 'host)': 0.16; 'record,': 0.16; 'later': 0.16; 'skip:= 20': 0.22; 'cc:2**0': 0.23; 'insert': 0.23; 'cc:no real name:2**0': 0.24; 'host': 0.24; 'cc:addr:python.org': 0.25; 'header:In-Reply-To:1': 0.25; 'header:User-Agent:1': 0.26; 'values': 0.26; 'first,': 0.27; 'record': 0.28; 'primary': 0.30; 'received:google.com': 0.34; 'received:209.85.220': 0.35; 'received:209.85': 0.35; 'received:209': 0.37; 'data': 0.37; 'subject:: ': 0.38; 'easier': 0.38; 'instead': 0.39; 'where': 0.40; 'save': 0.61; '8bit%:95': 0.61; 'dont': 0.64; 'skip:= 30': 0.64; 'date,': 0.65; '8bit%:100': 0.70; '8bit%:92': 0.70; '2013': 0.84; 'cid': 0.84; 'vid': 0.84; 'dennis': 0.91 X-Received: by 10.49.12.238 with SMTP id b14mr1760412qec.18.1359196542535; Sat, 26 Jan 2013 02:35:42 -0800 (PST) Newsgroups: comp.lang.python Date: Sat, 26 Jan 2013 02:35:42 -0800 (PST) In-Reply-To: Complaints-To: groups-abuse@google.com Injection-Info: glegroupsg2000goo.googlegroups.com; posting-host=94.68.70.179; posting-account=DYJQ-woAAACEPH85Au2BhUVfFTfSfVa4 References: <88306c73-dfa2-44e1-ab0c-d90dba05be1c@googlegroups.com> User-Agent: G2/1.0 X-Google-Web-Client: true X-Google-IP: 94.68.70.179 MIME-Version: 1.0 Subject: Re: mysql solution From: Ferrous Cranus To: comp.lang.python@googlegroups.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: python-list@python.org X-BeenThere: python-list@python.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: General discussion list for the Python programming language List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Message-ID: Lines: 35 NNTP-Posting-Host: 2001:888:2000:d::a6 X-Trace: 1359199323 news.xs4all.nl 6858 [2001:888:2000:d::a6]:37297 X-Complaints-To: abuse@xs4all.nl Xref: csiph.com comp.lang.python:37719 =CE=A4=CE=B7 =CE=A0=CE=B1=CF=81=CE=B1=CF=83=CE=BA=CE=B5=CF=85=CE=AE, 25 =CE= =99=CE=B1=CE=BD=CE=BF=CF=85=CE=B1=CF=81=CE=AF=CE=BF=CF=85 2013 11:56:44 =CE= =BC.=CE=BC. UTC+2, =CE=BF =CF=87=CF=81=CE=AE=CF=83=CF=84=CE=B7=CF=82 Dennis= Lee Bieber =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D #find the visitor record for the (saved) cID and current host=20 cur.execute('''SELECT * FROM visitors WHERE counterID =3D %s and host = =3D %s''', (cID, host) ) =20 data =3D cur.fetchone() #cID&host are unique =09 if not data: #first time for this host on this page, create new record=20 cur.execute('''INSERT INTO visitors (counterID, host, userOS, browser, = lastvisit) VALUES (%s, %s, %s, %s, %s)''', (cID, host, useros, browser, date) ) else: #found the page, save its primary key for later use=20 vID =3D data[0]=20 #UPDATE record using retrieved vID=20 cur.execute('''UPDATE visitors SET userOS =3D %s, browser =3D %s, hits = =3D hits + 1, lastvisit =3D %s WHERE counterID =3D %s and host =3D %s''', (useros, browser, date,= vID, host) ) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Instead of the above logic which you provided and it works as expected, wou= ldn't be easier to just: Try to update the 'visitors' record, for that 'page' and that 'host' if update fails(doesnt return any data), then we insert a new record entry. We dont have to check 'SELECT * FROM visitors WHERE counterID =3D %s and ho= st =3D %s' first, this one less cursor.execute.