Path: csiph.com!fu-berlin.de!uni-berlin.de!not-for-mail
From: Christopher Reimer <christopher_reimer@icloud.com>
Newsgroups: comp.lang.python
Subject: Re: How much sanity checking is required for function inputs?
Date: Thu, 21 Apr 2016 18:34:59 -0700
Lines: 55
Message-ID: <mailman.0.1461288908.2861.python-list@python.org>
References: <5713E52D.3060407@icloud.com> <1461131475.4042173.584042297.03DAB00E@webmail.messagingengine.com> <57171D23.40709@stoneleaf.us> <1461133057.4046578.584060569.2DD34821@webmail.messagingengine.com> <57185E88.30201@yahoo.com> <57197FC3.4030701@icloud.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
In-reply-to: <57185E88.30201@yahoo.com>
Precedence: list
Xref: csiph.com comp.lang.python:107469

Greetings,

Thanks to everyone for providing feedback. Here's my revised code to 
generate a set of chess pieces.


class PieceFactory(object):

         def factory(color, piece, position):
             if piece == 'Bishop':
                 return Bishop(color, position)
             if piece == 'King':
                 return King(color, position)
             if piece == 'Knight':
                 return Knight(color, position)
             if piece == 'Pawn':
                 return Pawn(color, position)
             if piece == 'Queen':
                 return Queen(color, position)
             if piece == 'Rook':
                 return Rook(color, position)

             raise PieceException('No valid Piece object for factory, 
got {}'
                                  ' instead'.format(piece))

         factory = staticmethod(factory)


def generate_set(color, pieces, positions):

     for piece, position in zip(pieces, positions):
         yield getattr(PieceFactory, 'factory')(color, piece, position)


The input values for 'pieces' and 'positions' are 16-item lists zipped 
together to produce a piece name and a position coordinate for the 
factory method. With slight modifications to the code, the factory 
method could also return checker pieces.

I got the factory method from here: 
http://python-3-patterns-idioms-test.readthedocs.org/en/latest/Factory.html

I do plan to incorporate a sanity test in each Piece class to validate 
the initial position value. Pawns have 16 specific positions. Bishop, 
Knight and Rook each have four specific positions. King and Queen each 
have two specific positions. An invalid value will raise an exception.

Finally, VARS['VARIABLE_NAME'] got change to const['variable_name']. 
Should smell better.

Thanks,

Chris R