Path: csiph.com!x330-a1.tempe.blueboxinc.net!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!border3.nntp.dca.giganews.com!Xl.tags.giganews.com!border1.nntp.dca.giganews.com!nntp.giganews.com!local2.nntp.dca.giganews.com!nntp.earthlink.com!news.earthlink.com.POSTED!not-for-mail
NNTP-Posting-Date: Thu, 12 Jan 2012 18:11:43 -0600
Date: Thu, 12 Jan 2012 16:11:43 -0800
From: Patricia Shanahan <pats@acm.org>
User-Agent: Thunderbird 1.5.0.2 (Windows/20060308)
MIME-Version: 1.0
Newsgroups: comp.lang.java.programmer
Subject: Re: Curious compiler warning
References: <Xns9FD6D451D5F1Djpnasty@94.75.214.39>	<jeir2s$7v0$3@news.albasani.net> <Xns9FD6F359B6B60jpnasty@94.75.214.39>	<dnlqg711uq7njg5bi19fhu76cc6ploibb9@4ax.com>	<9n64rgF40bU1@mid.individual.net>	<1igsg7d3eggiptf23g9vd0flv19ghqs83d@4ax.com> <jensb0$fae$2@localhost.localdomain>
In-Reply-To: <jensb0$fae$2@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Message-ID: <ZvCdnfCrF4Mi65LSnZ2dnUVZ_gqdnZ2d@earthlink.com>
Lines: 20
X-Usenet-Provider: http://www.giganews.com
NNTP-Posting-Host: 75.11.53.36
X-Trace: sv3-HlwNpnZi7A0a+hvtytbLoR5lJtTetMeP0S/vWaRsNBrSEpTonu2Qol4MuzYMPYLTAGdBBfFB30SmAiv!20bjd9O8agq+RmDvnTNb3iRmOfL2+iUZAi9K48LrDIu4pIPOmjWKKWGhoGjtgfJLRwXLTWTPwRvP!tIxM5fQRNiNCBxHTAGuK89ZX5/ISPE4wuFnhUF+GJUE=
X-Abuse-and-DMCA-Info: Please be sure to forward a copy of ALL headers
X-Abuse-and-DMCA-Info: Otherwise we will be unable to process your complaint properly
X-Postfilter: 1.3.40
X-Original-Bytes: 2138
Xref: x330-a1.tempe.blueboxinc.net comp.lang.java.programmer:11291

Martin Gregorie wrote:
> On Wed, 11 Jan 2012 18:18:57 -0800, Gene Wirchenko wrote:
> 
>>      Oh, my.  Bad style.  That is bad, isn't it?  I am wearing a dark
>> grey sweater and medium brown pants.  Is anyone's compiler concerned
>> about my style?
>>
> IMO the only egregiously bad style is not sticking to the style used by 
> the original programmer when you're amending the program. In my book this 
> is an invariant rule, no matter how obnoxious the original style is 
> because doing anything else is sure-fire way to make even very ugly code 
> much worse.
> 
> 

I agree. In a few cases, I've kept a shadow copy of some code that was
formatted with reasonable indentation etc. for reading, but still made
my changes in the original code, warts and all.

Patricia