Path: csiph.com!newsfeed.hal-mli.net!feeder3.hal-mli.net!newsfeed.hal-mli.net!feeder1.hal-mli.net!news.misty.com!news.iecc.com!.POSTED!nerds-end From: Bart Vandewoestyne Newsgroups: comp.compilers Subject: Tiger compiler, lexical analysis: looking for reviews and comments Date: Tue, 25 Sep 2012 05:40:18 -0700 (PDT) Organization: Compilers Central Lines: 30 Sender: johnl@iecc.com Approved: comp.compilers@iecc.com Message-ID: <12-09-019@comp.compilers> NNTP-Posting-Host: news.iecc.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: leila.iecc.com 1348672699 94538 64.57.183.58 (26 Sep 2012 15:18:19 GMT) X-Complaints-To: abuse@iecc.com NNTP-Posting-Date: Wed, 26 Sep 2012 15:18:19 +0000 (UTC) Keywords: question, lex Posted-Date: 26 Sep 2012 11:18:19 EDT X-submission-address: compilers@iecc.com X-moderator-address: compilers-request@iecc.com X-FAQ-and-archives: http://compilers.iecc.com Xref: csiph.com comp.compilers:755 Hello all, As a hobby and fun project, and partly also to improve my C programming skills, I have started working my way through Appel's 'Modern Compiler Implementation in C'. I have just finished chapter 2 on lexical analysis and I think I have a lexer which is quite ok. However, before I move on to chapter 2, i want to make sure my lexer is *more than* OK. So if you're interested, then I would like to ask you: 1) Please review my tiger.lex file from both the style point of view (indentation, comments, clean coding?) and from the correctness point of view. 2) Please stress-test my lexer and find bugs. If you find a bug, then please provide me a .tig file that illustrates what goes wrong and I will try to fix it myself. 3) If you have a GitHub account, feel free to follow me and send me pull requests with improvements. If you don't have a GitHub account, create one, because social coding rockzzz! ;-) Any other suggestions or comments are also always welcome! My code can be found on GitHub in the chap02 directory at https://github.com/BartVandewoestyne/c/tree/master/books/Modern_Compiler_Implementation_in_C/ Regards, Bart